Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug and added functionality to metapred and fixed tests #4

Merged
merged 20 commits into from
Feb 19, 2024

Conversation

VMTdeJong
Copy link
Collaborator

  1. Fixed bug in metapred where multiple genFUN raised an error. Added parameter to allow for multiple options for handling multiple genFUN and perfFUN simultaneously. Changed gen so that multiple generalizability estimates can be retrieved simultaneously.
  2. Added tests for multiple generalizability and performance functions in metapred. This should prevent the fixed bug from reoccuring.
  3. Fixed test that raised an error when plotting valmeta. Note that the statistical issue remains, just the test is fixed.
  4. Split tests for ccalc and oecalc into three. Note that this highlights an unintended difference in estimates, which fails the test.

Changed CI for valmeta for forest plot, to prevent unnecessary error in test.
Split tests for oecalc into three. Note that this change highlights that the tests fail for Poisson Binomial OE ratio.
Split test for ccalc into three.
Automatic change due to test change
Changed plotting options, per new preferences in ggplot. This also removes warnings in the tests.
Added function for retrieving multiple functions, which metapred uses to find functions.
Changed tests such that manual testing is easier - automatic testing remains functional.
Fixed bug in metapred where multiple genFUN raised an error. Added parameter to allow for multiple options for handling multiple genFUN and perfFUN simultaneously. Changed gen so that multiple generalizability estimates can be retrieved simultaneously.
Added tests for multiple generalizability and performance functions in metapred. This should prevent the fixed bug from reoccuring.
Removed empty sections from Tzoulaki manual
added docs for applying multiple generalizability and performance measures simultaneously in metapred
Added tolerance to tests for oecalc
changed ci to t dist for test of valmeta oe
Added one-stage random effects for metapred, and tests
added option for perf() of metapred
added tests for one-stage models in metapred
fixed perf, which was failing a test for type of output
fixed test for one-stage random effects metapred
@VMTdeJong VMTdeJong merged commit af02eea into main Feb 19, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant